Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(): bug report form #8315

Closed
wants to merge 89 commits into from
Closed

ci(): bug report form #8315

wants to merge 89 commits into from

Conversation

ShaMan123
Copy link
Contributor

@ShaMan123 ShaMan123 commented Sep 25, 2022

First merge #8189

  • Added a github action to have the user check some boxes before opening an issue
  • Added a github action to automatically update the list of available versions for the form to choose from

readme...bug-report-form

- [ ] I have read and followed the [Contributing Guide](/CONTRIBUTING.md)
- [ ] I have read and followed the [Issue Tracker Guide](/CONTRIBUTING.md#%EF%B8%8F-issue-tracker)
- [ ] I have searched and referenced existing issues and discussions
- [ ] I have managed to reproduce the bug **after** upgrading to the **latest** version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or latest version of the same major version ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why actually?
Do we want that?
Supporting old majors?
I don't

- 0.5.6
- 0.5.5
- 0.5.3
- 0.5.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh. I would propose only the newest from every major is available, from 2.x up

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is generated by the action.
I can do a min version and from that onwards.
Good enough?

CONTRIBUTING.md Outdated
@@ -16,7 +16,7 @@ Demos and examples 🤓 can be found on [fabricjs.com](http://fabricjs.com/demos
## 🏷️ Issue Tracker

- **Before You Begin** 🎬
- 📌 Make sure you didn't fall into a known [**GOTCHA**](http://fabricjs.com/fabric-gotchas)
- 📌 Make sure you didn't fall into a known [**GOTCHA**](./GOTCHAS.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would like to leave the link to the website. The money from the ads corner ( is not even a banner ) can be useful at some point

@asturur
Copy link
Member

asturur commented Sep 25, 2022

Did you put back all the doc pr here? i realized after reading half of it

@asturur
Copy link
Member

asturur commented Sep 25, 2022

oh it was in the description

- run: node scripts/updateBugReportVersion.mjs
env:
VERSION: ${{ github.event.release.tag_name }}
- run: git commit -m "ci(): update bug report version" -a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't mind an automatic commit per release, till we release once in a while.
But if we release each small bugfix ( auspicable ) this becomes like the automatic changelog

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explain your concerns?
history pollution?
We can change this action to run chronologically instead, once a week or 2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will extract the action logic anyways to a standalone action

@ShaMan123
Copy link
Contributor Author

I think I will close this PR now that I have authored an action for the form's version and merge the form into #8189

@ShaMan123 ShaMan123 marked this pull request as draft September 26, 2022 11:51
@ShaMan123
Copy link
Contributor Author

ported to #8189

todo

  • gotchas link

@ShaMan123 ShaMan123 closed this Sep 28, 2022
@ShaMan123 ShaMan123 deleted the bug-report-form branch December 22, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants